Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Canvas elements #42473

Merged
merged 22 commits into from
Aug 21, 2019
Merged

[DOCS] Canvas elements #42473

merged 22 commits into from
Aug 21, 2019

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Aug 1, 2019 •
edited
Loading

Summary

This PR:

[skip ci]

Checklist

  • Documentation was added for features that require explanation or tutorials

@KOTungseth KOTungseth added the WIP Work in progress label Aug 1, 2019
@KOTungseth KOTungseth self-assigned this Aug 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@KOTungseth KOTungseth added review and removed WIP Work in progress labels Aug 12, 2019
@KOTungseth KOTungseth marked this pull request as ready for review August 12, 2019 21:41
@KOTungseth KOTungseth requested a review from gchaps August 12, 2019 21:53
timductive
timductive requested changes Aug 13, 2019
View reviewed changes
docs/canvas/canvas-workpad.asciidoc Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
@timductive
Copy link
Member

I saw this PR is tagged for 7.0 and forward, I'm not sure how docs versioning works but just to note that some of these docs only apply to 7.3 and later.

@KOTungseth KOTungseth added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Aug 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

gchaps
gchaps reviewed Aug 13, 2019
View reviewed changes
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated

To create a dynamic, multi-page, pixel perfect presentation, create and build your Canvas workpad.

In need of some workpad inspiration? Check out the link:https://www.elastic.co/blog/[Elastic Blog].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to something more specific to Canvas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We create new Canvas blogs quite frequently, so I'm afraid if we link to a specific blog, it will quickly become stale.

docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-workpad.asciidoc Outdated Show resolved Hide resolved
cqliu1
cqliu1 reviewed Aug 19, 2019
View reviewed changes
docs/canvas/canvas-elements.asciidoc

[float]
[[element-save]]
=== Save elements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a GIF for this section? I can record one for you if you need.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be super helpful, thank you!

cqliu1
cqliu1 requested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs look great! I made a some suggestions here and there, but I'm nitpicking.

@KOTungseth KOTungseth merged commit 5fe9d0e into elastic:master Aug 21, 2019
@KOTungseth KOTungseth deleted the docs/canvas-elements branch August 21, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@cqliu1 cqliu1 cqliu1 approved these changes

@timductive timductive timductive approved these changes

Assignees

@KOTungseth KOTungseth

Labels
release_note:enhancement review Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.3.0 v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Canvas] Document editing interactions
5 participants
@KOTungseth @elasticmachine @timductive @cqliu1 @gchaps